feat: add `math/base/special/fast/atanhf` by nakul-krishnakumar · Pull Request #9046 · stdlib-js/stdlib

nakul-krishnakumar · 2025-12-14T20:01:33Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: passed
task: lint_c_examples status: passed
task: lint_c_benchmarks status: passed
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves a part of #649 .

Description

What is the purpose of this pull request?

This pull request:

Adds math/base/special/fast/atanhf.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

nakul-krishnakumar · 2025-12-14T20:02:35Z

/stdlib update-copyright-years

stdlib-bot · 2025-12-14T20:03:44Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/fast/atanhf	$\color{green}188/188$ $\color{green}+0.00%$	$\color{green}10/10$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}188/188$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

gunjjoshi · 2025-12-31T05:49:58Z

lib/node_modules/@stdlib/math/base/special/fast/atanhf/README.md

+
+```c
+float out = stdlib_base_fast_atanhf( 0.0f );
+// returns 0.0


Suggested change

// returns 0.0

// returns 0.0f

gunjjoshi · 2025-12-31T05:50:09Z

lib/node_modules/@stdlib/math/base/special/fast/atanhf/README.md

+// returns 0.0
+
+out = stdlib_base_fast_atanhf( -0.0f );
+// returns -0.0


Suggested change

// returns -0.0

// returns -0.0f

gunjjoshi · 2025-12-31T06:06:37Z

lib/node_modules/@stdlib/math/base/special/fast/atanhf/examples/c/example.c

+	int i;
+
+	for ( i = 0; i < 100; i++ ) {
+		x = ( (float)rand() / (float)RAND_MAX ) * 100.0f;


@nakul-krishnakumar The domain of atanhf is restricted to [-1.0, 1.0]. But here, you are generating example values in the [0, 100) domain. We'll need to change this. You can do something like this: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/fast/atanh/examples/c/example.c

Thank you for the review, I will update as suggested! @gunjjoshi

gunjjoshi · 2025-12-31T06:08:27Z

lib/node_modules/@stdlib/math/base/special/fast/atanhf/README.md

+    int i;
+
+    for ( i = 0; i < 100; i++ ) {
+        x = ( (float)rand() / (float)RAND_MAX ) * 100.0f;


Same comment regarding the domain of atanhf.

gunjjoshi · 2025-12-31T06:14:55Z

lib/node_modules/@stdlib/math/base/special/fast/atanhf/benchmark/c/native/benchmark.c

+	int i;
+
+	for ( i = 0; i < 100; i++ ) {
+		x[ i ] = random_uniform( 0.0f, 100.0f );


Same thing here. We must generate values between [-1.0, 1.0].

gunjjoshi · 2025-12-31T06:15:59Z

lib/node_modules/@stdlib/math/base/special/fast/atanhf/test/test.native.js

+var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
+var randu = require( '@stdlib/random/base/randu' );
+var ulpdiff = require( '@stdlib/number/float32/base/ulp-difference' );
+var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zero' );


Suggested change

var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zero' );

var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );

gunjjoshi · 2025-12-31T06:17:21Z

lib/node_modules/@stdlib/math/base/special/fast/atanhf/package.json

+{
+  "name": "@stdlib/math/base/special/fast/atanhf",
+  "version": "0.0.0",
+  "description": "Compute the hyperbolic arctangent of single-precision floating-point number.",


Suggested change

"description": "Compute the hyperbolic arctangent of single-precision floating-point number.",

"description": "Compute the hyperbolic arctangent of a single-precision floating-point number.",

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

nakul-krishnakumar · 2026-01-01T17:15:05Z

@gunjjoshi Thank you for the review! I have made all the requested changes.

nakul-krishnakumar · 2026-01-01T17:15:41Z

/stdlib update-copyright-years

lib/node_modules/@stdlib/math/base/special/fast/atanhf/benchmark/c/native/benchmark.c

Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>

kgryte · 2026-01-05T23:30:53Z

/stdlib merge

lib/node_modules/@stdlib/math/base/special/fast/atanhf/benchmark/benchmark.js

lib/node_modules/@stdlib/math/base/special/fast/atanhf/benchmark/benchmark.native.js

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter

PR is in great shape now, thank you @nakul-krishnakumar and @gunjjoshi for reviews!

stdlib-bot · 2026-01-07T05:44:11Z

PR Commit Message

feat: add `math/base/special/fast/atanhf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/9046
Ref: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 14, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 14, 2025

chore: update copyright years

633e3ae

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 14, 2025

gunjjoshi reviewed Dec 31, 2025

View reviewed changes

gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2025

nakul-krishnakumar added 2 commits January 1, 2026 22:32

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2026

chore: update copyright years

329b32d

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2026

nakul-krishnakumar commented Jan 1, 2026

View reviewed changes

lib/node_modules/@stdlib/math/base/special/fast/atanhf/benchmark/c/native/benchmark.c Outdated Show resolved Hide resolved

chore: use single precision floating points

594a23a

Signed-off-by: Nakul Krishnakumar <nakulkrishnakumar86@gmail.com>

nakul-krishnakumar requested a review from gunjjoshi January 1, 2026 17:18

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 1, 2026

kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jan 2, 2026

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 5, 2026

kgryte requested a review from anandkaranubc January 5, 2026 23:31

Merge remote-tracking branch 'upstream/develop' into fast-atanhf

f77d5b0

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 5, 2026

Planeshifter reviewed Jan 7, 2026

View reviewed changes

lib/node_modules/@stdlib/math/base/special/fast/atanhf/benchmark/benchmark.js Outdated Show resolved Hide resolved

Planeshifter reviewed Jan 7, 2026

View reviewed changes

lib/node_modules/@stdlib/math/base/special/fast/atanhf/benchmark/benchmark.native.js Show resolved Hide resolved

bench: avoid unneeded else clause

29db97f

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter approved these changes Jan 7, 2026

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 7, 2026

Planeshifter merged commit cb09f58 into stdlib-js:develop Jan 7, 2026
31 checks passed

stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026

	var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zero' );
	var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );

	"description": "Compute the hyperbolic arctangent of single-precision floating-point number.",
	"description": "Compute the hyperbolic arctangent of a single-precision floating-point number.",

Uh oh!

Conversation

nakul-krishnakumar commented Dec 14, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

nakul-krishnakumar commented Dec 14, 2025

Uh oh!

stdlib-bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

gunjjoshi Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nakul-krishnakumar Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

nakul-krishnakumar commented Jan 1, 2026

Uh oh!

nakul-krishnakumar commented Jan 1, 2026

Uh oh!

Uh oh!

kgryte commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jan 7, 2026 • edited by Planeshifter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stdlib-bot commented Dec 14, 2025 •

edited

Loading

gunjjoshi Dec 31, 2025 •

edited

Loading

Planeshifter left a comment •

edited

Loading

stdlib-bot commented Jan 7, 2026 •

edited by Planeshifter

Loading